[DDC-1572] Allow LIKE pattern to be a function or path expression #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm wondering about the use of functions in the pattern of a LIKE clause. Is it supported by all RDBMS targeted by Doctrine ? |
|
Guilherme - I've fixed the docblock. Stof - I think yes. I've tested it only on sqlite, mysql, postgresql and oracle, and I think, that mssql and db2 will support it too. |
|
@stof yes, it is supported. |
guilhermeblanco
added a commit
that referenced
this pull request
Dec 31, 2011
[DDC-1572] Allow LIKE pattern to be a function or path expression
This was referenced Dec 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fix like expression parser as well as SqlWalker to allow the pattern to be a function or path expression (another column for example joined column), to allow such where conditions:
LOWER(u.field) LIKE LOWER(?1) or with joined tables - log.messages LIKE alert.pattern
I do not know if I fixed that in the correct way, because I am not familiar with Doctrine2 query parsers and lexers.
I've created also few test cases for that and it works.